Bug #63

fixes in StdStamps

Added by J. Templ about 4 years ago. Updated almost 4 years ago.

Status:ClosedStart date:06/18/2015
Priority:NormalDue date:
Assignee:J. Templ% Done:

0%

Category:-
Target version:1.7
Forum topic:

Description

The following problems have been identified for module StdStamps:
- changing non-empty comment to empty comment corrupts the file format
- storing multiple times on the same day adds zero entries to the history
- comments are always related to the first stamp in the focus text
- comments and date/time of old entries cannot be edited
- uncommented entries should be removed first in case of overflow
- text marked 'to be removed soon' should be removed
- formal parameters should use IN resp. OUT in "Stamp" & "GetInfo".
A proposal for the changes by Helmut Zinn and Robert Campbell exists in CPC 1.7 rc6.

The issue has been reported by Robert Campbell, 2015-01-24.

Associated revisions

Revision 92dcc60b
Added by J. Templ almost 4 years ago

editing of old comments added. Refs: #63.
Very much as proposed by Robert Campbell in CPC 1.7rc5
with some adaptations in order to preserve the previous behavior as much as possible.

Signed-off-by: Josef Templ <>

Revision 962847e6
Added by J. Templ almost 4 years ago

option 'Force New' added to dialog. Refs: #63.
Several details improved as proposed by Robert.

Signed-off-by: Josef Templ <>

Revision cf2b7965
Added by J. Templ almost 4 years ago

comment editing improved. Refs: #63.
Improvements as suggested by Robert and Helmut:
- option 'Force New' removed from dialog
- selecting 'Age 0' means 'Force New'.
- 'Age 0' comment shown in history with 'seq nr=####'
- docu updated accordingly

Dialog.MapString used for header line of history.
Open dialog box set to Age 1 upon Externalize.

Signed-off-by: Josef Templ <>

Revision 8ea0463f
Added by J. Templ almost 4 years ago

field 'Age' removed. Refs: #63.
The indirect selection of a sequence number via field 'Age' has been removed.
The sequence number of old sessions is now directly selectable
via a list box with existing sequence numbers plus a first entry named 'new'
for adding a new entry to the history.
ShowHistory has been slightly improved for 'new' entries
in order to align the appearance of new entries in the history
with the information in the dialog box.

Signed-off-by: Josef Templ <>

Revision d2a89e96
Added by J. Templ almost 4 years ago

bugs fixed in GetData. Refs: #63.
As pointed out by Robert, the comment field must be
tested for NIL before string assignment.
Also, there should be an explicit check of entryno overflow
because the fixed size history array may only be filled partially.

Signed-off-by: Josef Templ <>

Revision 529e3857
Added by J. Templ almost 4 years ago

Comment exported; history with dynamic length. Refs: #63.
As proposed by Robert.

Signed-off-by: Josef Templ <>

Revision 8b4e89e7
Added by J. Templ almost 4 years ago

additional copy operations in CopyFromSimpleView. Refs: #63.
- comment0 copied as suggested by Robert.
- history entry 0 always copied because it contains the date of today
which is used in case of a newly created stamp; suggested by Robert.
- Forward declaration of Update removed as suggested by Helmut.

Signed-off-by: Josef Templ <>

Revision 03e2eccc
Added by J. Templ almost 4 years ago

Merge pull request #71 from BlackBoxCenter/issue-#63

additional copy operations in CopyFromSimpleView. Refs: #63.

Revision 100b898f
Added by J. Templ over 3 years ago

purge uncommented entry if another entry for the same date exists. Refs: #63.
As proposed by Robert.
Since preventing the creation of an uncommented entry for a date where a commented entry already exists is more complicated, such entries are purged in Internalize. This also purges such entries that may already exist in documents.

Signed-off-by: Josef Templ <>

Revision e132098c
Added by J. Templ over 3 years ago

Merge pull request #77 from BlackBoxCenter/issue-#63

purge uncommented entry if another entry for the same date exists. Refs: #63.

History

#1 Updated by J. Templ almost 4 years ago

  • Status changed from New to Closed

Also available in: Atom PDF